feat(Teams): backport support for teams #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdistin
suggested changes
Jun 26, 2019
src/structures/OAuth2Application.js
Outdated
| * The owning team of this OAuth application | ||
| * @type {?Team} | ||
| */ | ||
| this.team = new Team(this.client, data.team); |
There was a problem hiding this comment.
The team property should always exist as null or Team, not excluding the property if no data.team, so the object keeps consistent shape.
There was a problem hiding this comment.
Well, and also, it should be deprecated since it will be gone in v12.
There was a problem hiding this comment.
How would such a deprecation look like? Emitting a process warning on access seems unjustified as there is no way to fix this before v12. Maybe a warn or info in the documentation?
There was a problem hiding this comment.
At minimum just a docstring @deprecated. But probably that with an explanation (in a warn or info tag) in the description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR backports #3350 (a22aabf) in a semver-minor manner.
(Namingly adding a
teamproperty opposed to replacingowner)Status
Semantic versioning classification: