Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Structure): ReactionUserStore#remove() cause event messageReactionRemove to fires twice #3277

Merged
merged 1 commit into from Aug 17, 2019
Merged

Fix(Structure): ReactionUserStore#remove() cause event messageReactionRemove to fires twice #3277

merged 1 commit into from Aug 17, 2019

Conversation

KhooHaoYit
Copy link
Contributor

@KhooHaoYit KhooHaoYit commented May 17, 2019

This PR fixes #3268.
Please describe the changes this PR makes and why it should be merged:
Same problem as #3252.

ReactionUserStore#remove() execute messageReactionRemove action handler.
After that, it got executed again by the WebSocketManager.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@bsantosh909
Copy link

bsantosh909 commented May 18, 2019

I dont know about the internals, but yeah that fixes the Issue.

Just tested out the branch of PR with the same code and got the proper result as expected in #3268

@SpaceEEC SpaceEEC merged commit 1851f74 into discordjs:master Aug 17, 2019
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

messageReactionRemove firing twice
3 participants