Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structures.extend checks the prototype chain #3217

Merged
merged 1 commit into from Apr 21, 2019
Merged

Structures.extend checks the prototype chain #3217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/util/Structures.js
View file
Open in desktop
Expand Up @@ -55,8 +55,8 @@ class Structures {
throw new TypeError(`The extender function must return the extended structure class/prototype ${received}.`);
}

const prototype = Object.getPrototypeOf(extended);
if (prototype !== structures[structure]) {
if (!(extended.prototype instanceof structures[structure])) {
const prototype = Object.getPrototypeOf(extended);
const received = `${extended.name || 'unnamed'}${prototype.name ? ` extends ${prototype.name}` : ''}`;
throw new Error(
'The class/prototype returned from the extender function must extend the existing structure class/prototype' +
Expand Down