Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Fix resume event not being emitted properly #3192

Merged
merged 6 commits into from Apr 21, 2019
Merged

src: Fix resume event not being emitted properly #3192

merged 6 commits into from Apr 21, 2019

Commits on Apr 9, 2019

  1. src: Fix shardResumed event not being emitted

    @vladfrangu
    vladfrangu committed Apr 9, 2019
    Copy the full SHA
    0d836d4 View commit details
    Browse the repository at this point in the history

  2. docs: Document Client#error again

    @vladfrangu
    vladfrangu committed Apr 9, 2019
    Copy the full SHA
    2eece4b View commit details
    Browse the repository at this point in the history

  3. src: Fix onError due to incorrect typings

    @vladfrangu
    vladfrangu committed Apr 9, 2019
    Copy the full SHA
    31d72ea View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. src: handle onError properly for both uws and ws

    @vladfrangu
    vladfrangu committed Apr 10, 2019
    Copy the full SHA
    387fee5 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2019

  1. src: Try to fix silent disconnects when using uWs

    @vladfrangu
    vladfrangu committed Apr 14, 2019
    Copy the full SHA
    bd8ac4d View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2019

  1. fix(WebSocketShard): uws emits plain objects, not errors 

    Emitting line of code: https://github.com/discordjs/uws/blob/39aa429f94d9668608f69848b3a84db3a3e92914/src/uws.js#L80-L83
Listener attaching is here: https://github.com/discordjs/uws/blob/master/src/uws.js#L128
For reference, found a clue here: discordjs#1528
    @SpaceEEC
    SpaceEEC committed Apr 21, 2019
    Copy the full SHA
    929bc58 View commit details
    Browse the repository at this point in the history