Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-extractor-model): resolve doc reference for classes with merged interfaces #10225

Merged
merged 1 commit into from
Apr 27, 2024
Merged

fix(api-extractor-model): resolve doc reference for classes with merged interfaces #10225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/api-extractor-model/src/model/ModelReferenceResolver.ts
View file
Open in desktop
Expand Up @@ -113,11 +113,19 @@ export class ModelReferenceResolver {
const memberSelector: DocMemberSelector | undefined = memberReference.selector;
if (memberSelector === undefined) {
if (foundMembers.length > 1) {
result.errorMessage = `The member reference ${JSON.stringify(identifier)} was ambiguous`;
return result;
const foundClass: ApiItem | undefined = foundMembers.find((member) => member.kind === ApiItemKind.Class);
Jiralite marked this conversation as resolved.
Show resolved Hide resolved
if (
foundClass &&
foundMembers.filter((member) => member.kind === ApiItemKind.Interface).length === foundMembers.length - 1
) {
currentItem = foundClass;
} else {
result.errorMessage = `The member reference ${JSON.stringify(identifier)} was ambiguous`;
return result;
}
} else {
currentItem = foundMembers[0]!;
}

currentItem = foundMembers[0]!;
} else {
let memberSelectorResult: IResolveDeclarationReferenceResult;
switch (memberSelector.selectorKind) {
Expand Down