feat: polls #10185
Merged
feat: polls #10185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
almeidx
force-pushed
the
feat/polls
branch
2 times, most recently
from
31465b2
to
670efe1
Compare
almeidx
force-pushed
the
feat/polls
branch
5 times, most recently
from
d5f34c7
to
33bc1f9
Compare
vladfrangu
reviewed
Apr 27, 2024
vladfrangu
approved these changes
Apr 30, 2024
iCrawl
approved these changes
Apr 30, 2024
Jiralite
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Added support for polls.
Decided to take an opinionated stance with the poll results here. Instead of having a separate structure (
results) like Discord, the answer vote count has been inlined directly into PollAnswer (e.g.poll.results.answer_counts[].count->poll.answers[].voteCount), as it seemed to provide better DX to me. Additionally, also flattened all Poll Media objects (e.g.poll.question.text->poll.question)Upstream:
Depends on:
Status and versioning classification: