types: Use ThreadChannel and AnyThreadChannel consistently
#10181
+34
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RedGuy12
changed the title
ThreadChannel and AnyThreadChannel consistently
vladfrangu
previously requested changes
Mar 20, 2024
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
RedGuy12
force-pushed
the
fix-thread-types
branch
from
241bda6
to
15862db
Compare
Qjuh
suggested changes
Mar 27, 2024
Signed-off-by: cobalt <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: cobalt <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: cobalt <61329810+RedGuy12@users.noreply.github.com>
vladfrangu
requested changes
Apr 30, 2024
| MessageManager: [manager: typeof MessageManager, holds: typeof Message]; | ||
| // TODO: PermissionOverwriteManager: [manager: typeof PermissionOverwriteManager, holds: typeof PermissionOverwrites]; | ||
| PresenceManager: [manager: typeof PresenceManager, holds: typeof Presence]; | ||
| ReactionManager: [manager: typeof ReactionManager, holds: typeof MessageReaction]; | ||
| ReactionUserManager: [manager: typeof ReactionUserManager, holds: typeof User]; | ||
| // TODO: RoleManager: [manager: typeof RoleManager, holds: typeof Role]; | ||
| StageInstanceManager: [manager: typeof StageInstanceManager, holds: typeof StageInstance]; | ||
| ThreadManager: [manager: typeof ThreadManager, holds: typeof ThreadChannel]; | ||
| ThreadManager: [manager: typeof ThreadManager, holds: AnyThreadChannel]; |
There was a problem hiding this comment.
My hunch was correct: this creates a discrepancy between what the makeCache method gets (manager, class, manager) and what the types imply when a threadmanager is brought into the mix (which implies the class is an instance). This still needs a typeof in some form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I've been having issues with some methods returning
ThreadChanneland some returningAnyThreadChannel. This PR makes how we use each consistent.ThreadOnlyChannelwill always bePublicThreadChannel<true>), that is used.AnyThreadChanneltype.ThreadChanneltype. Typically, the user shouldn't have to useThreadChannelin their codebase at all (since all userland-facing values have been changed toAnyThreadChannel), but it doesn't hurt to allow it here.Status and versioning classification: