fix: Update tsconfig to address type checking issues #10104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to address type checking issues
FabricSoul
requested review from
monbrey,
vladfrangu,
iCrawl,
almostSouji,
Jiralite and
suneettipirneni
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How does the |
codershiba
reviewed
Jan 30, 2024
Co-authored-by: codershiba <155646804+codershiba@users.noreply.github.com>
vladfrangu
requested changes
Feb 23, 2024
| "skipLibCheck": true | ||
| "skipLibCheck": true, | ||
| "strictNullChecks": true, | ||
| "allowImportingTsExtensions": true |
There was a problem hiding this comment.
This should only be enabled for deno/bun, not every TS project! 👀
FabricSoul
commented
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR updates the
tsconfig.jsonfile by enablingstrictNullChecks,noEmit, andallowImportingTsExtensionsoptions. These changes improve the type checking process by ensuring that null and undefined values are handled correctly, preventing type-related runtime errors. Furthermore, thenoEmitoption is set to true to enable type-checking without compiling the code, suitable for our current build process.Status and versioning classification: