Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(guild): Remove deprecated get guild overload #10052

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(guild): Remove deprecated get guild overload #10052

wants to merge 2 commits into from

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Dec 14, 2023 •
edited by Jiralite

Please describe the changes this PR makes and why it should be merged:
Removes the deprecated overload from getting a guild.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@jaw0r3k jaw0r3k requested a review from a team as a code owner December 14, 2023 20:25
@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 9:53pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 9:53pm

@Jiralite Jiralite added this to the core 1.2.0 milestone Dec 14, 2023
@Jiralite Jiralite removed this from the core 1.2.0 milestone Dec 14, 2023
didinele
didinele previously requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointless to block such a trivially backwards compatible change until the next major. We should just make overloads and deprecate the current one, IMO.

@jaw0r3k
Copy link
Contributor Author

jaw0r3k commented Jan 22, 2024 •
edited

I guess we can, but do we want to put as much effort in it, especially that is is not that important
Just wait for next major which probably is not going to be that far away from now
And yup instead of typing that i could just do it

@didinele
Copy link
Member

yes, I'd advise you just do it, it takes like 2 minutes.

@jaw0r3k
Copy link
Contributor Author

jaw0r3k commented Jan 22, 2024

so just add an overload for the past behavior and check if the reason property exists in the object

@didinele
Copy link
Member

yes.

@Jiralite Jiralite changed the title fix(guild): allow to pass query into get feat(guild): allow to pass query into get Feb 21, 2024
@Jiralite
Copy link
Member

Opened #10143: a non-breaking pull request. This one may remain for the next major version.

@Jiralite Jiralite changed the title feat(guild): allow to pass query into get refactor(guild): Remove deprecated get guild overloadxxx Feb 21, 2024
@Jiralite Jiralite changed the title refactor(guild): Remove deprecated get guild overloadxxx refactor(guild): Remove deprecated get guild overload Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@benjGam benjGam benjGam approved these changes

@didinele didinele didinele left review comments

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
blocked packages:core refactor semver:major
Projects
discord.js
Status: Review Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jaw0r3k @didinele @Jiralite @vladfrangu @kyranet @suneettipirneni @benjGam