Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Activity): Fix equals() not checking for differing emoji #8841

Merged
merged 6 commits into from Nov 25, 2022
Merged

fix(Activity): Fix equals() not checking for differing emoji #8841

merged 6 commits into from Nov 25, 2022

Conversation

Eejit43
Copy link
Contributor

@Eejit43 Eejit43 commented Nov 16, 2022

This PR fixes Activity.equals() not checking for differing emojis, leading presenceUpdate to not fire if only a custom status emoji was updated.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 5:12PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 5:12PM (UTC)

Co-authored-by: Almeida <almeidx@pm.me>
@Eejit43 Eejit43 changed the title fix(Activity) Fix equals() not checking for differing emoji fix(Activity): Fix equals() not checking for differing emoji Nov 16, 2022
@Jiralite Jiralite added this to the discord.js v14.7 milestone Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #8841 (dfc455d) into main (d275480) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head dfc455d differs from pull request most recent head 38e6b3d. Consider uploading reports for the commit 38e6b3d to get more accurate results

@@            Coverage Diff             @@
##             main    #8841      +/-   ##
==========================================
- Coverage   85.63%   85.61%   -0.03%     
==========================================
  Files          96       96              
  Lines        9475     9459      -16     
  Branches     1137     1134       -3     
==========================================
- Hits         8114     8098      -16     
  Misses       1319     1319              
  Partials       42       42              
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.65% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/collection/src/collection.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants