Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Locales to Interactions #7131

Merged
merged 4 commits into from Jan 11, 2022
Merged

feat: Add Locales to Interactions #7131

merged 4 commits into from Jan 11, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Adds support for locales in interactions.

Ref:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

ImRodry
ImRodry suggested changes Dec 20, 2021
View reviewed changes
src/structures/Interaction.js Outdated Show resolved Hide resolved
src/structures/Interaction.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC added this to the Version 13.x milestone Dec 20, 2021
@Glazelf Glazelf mentioned this pull request Dec 22, 2021
Closed
18 tasks
Jiralite
Jiralite reviewed Dec 22, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@kyranet kyranet requested a review from iCrawl December 22, 2021 19:05
@iCrawl iCrawl modified the milestones: Version 13.x, Version 14 Dec 24, 2021
@Smidul
Copy link

Smidul commented Jan 11, 2022

Upstream PR merged 👀

@suneettipirneni
Copy link
Member Author

Rebased

@DTrombett DTrombett mentioned this pull request Jan 11, 2022
Closed
2 tasks
@iCrawl iCrawl merged commit 9052e32 into discordjs:main Jan 11, 2022
iCrawl pushed a commit that referenced this pull request Jan 13, 2022
@suneettipirneni @ImRodry @iCrawl
feat: add Locales to Interactions (#7131)
233084a 
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
@suneettipirneni suneettipirneni deleted the feat/locales branch February 7, 2022 16:25
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite left review comments

@ImRodry ImRodry ImRodry requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
api support discord packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@suneettipirneni @Smidul @vladfrangu @iCrawl @kyranet @SpaceEEC @Jiralite @ImRodry