Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support #107

Closed
12 of 18 tasks
Exorcism0666 opened this issue May 21, 2021 · 4 comments
Closed
12 of 18 tasks

Language support #107

Exorcism0666 opened this issue May 21, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request low priority will fix (later)

Comments

@Exorcism0666
Copy link
Contributor

Exorcism0666 commented May 21, 2021

Describe the solution you'd like

Why not add in the parameters a command which would allow to change the language of Ninigi, for example: in French, Spanish, Chinese etc ...

Describe alternatives you've considered

seeing that I am French I could help you if you want hehe (if you want to add this option of course)

DoD (added here and maintained by Glaze so it shows up in Issues list):

  • Put all English responses in a json file.
  • Readjust code everywhere to accomodate for language setup.
  • Move all commands
  • Move all events
  • Move all affairs
  • Move all other guild-specific text
  • Read from json file correctly.
  • Load all language strings on boot so that they don't have to be loaded every time a command is used.
  • Get correct language set in message event, pass through to command to avoid code repetition.
  • Add language per server to database.
  • Make command to swap between different language files, preferably adaptively based on the file name. (example: ?language jp reads jp.json)
  • Variables: let string = string.replace('[0]', variable);?
  • Default to English if no language is set
  • Default to English string if string is missing from that specific language.
  • Find a good way for people to contribute.
    Look into https://poeditor.com/projects/view?id=444591 & https://crowdin.com/
  • Make Pokémon command get different language API responses.
  • Translate Shinx commands.
  • If message is ephemeral use user's locale, otherwise use guild's language, replacing ?language command.
@Exorcism0666 Exorcism0666 added the enhancement New feature or request label May 21, 2021
@Glazelf
Copy link
Owner

Glazelf commented May 21, 2021

Why not add in the parameters a command which would allow to change the language of Ninigi, for example: in French, Spanish, Chinese etc ...

Would be quite a big task since I would need to make language files for every supported language but not impossible for sure.
I don't know if I could easily translate all the command names like ?togglechannel to all languages without messing up the code but just the responses Ninigi seems back should be possible.

seeing that I am French I could help you if you want hehe (if you want to add this option of course)

I only speak Dutch, which is a translation noone needs, so for other languages I would need others to translate instead yeah lmao

@Glazelf Glazelf changed the title Suggestion Language support May 21, 2021
@Glazelf Glazelf pinned this issue Aug 28, 2021
@Glazelf Glazelf linked a pull request Sep 4, 2021 that will close this issue
@Glazelf Glazelf unpinned this issue Oct 5, 2021
@Glazelf Glazelf added the low priority will fix (later) label May 21, 2022
@Glazelf
Copy link
Owner

Glazelf commented Jun 7, 2022

Slash commands will get new localization options soon, at which point most of this can likely be redone aside from the actual translations. Cool.

@Glazelf
Copy link
Owner

Glazelf commented Jul 8, 2022

This entire issue will likely have to restart development due to slash command support and the slash command language support beta.
One day. Maybe.
https://discord.com/developers/docs/interactions/application-commands#localization

@Glazelf
Copy link
Owner

Glazelf commented Nov 30, 2022

Closing this for now as I would have to restart development anyways. Might get back to this and will just make a new, clean issue for it.

@Glazelf Glazelf closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority will fix (later)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants