Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x-super-properties header #2586

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add x-super-properties header #2586

wants to merge 2 commits into from

Conversation

MinnDevelopment
Copy link
Member

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This adds support for the X-Super-Properties header in JDA. This header is required to use certain features in the API that discord forgot about.

@MinnDevelopment
Copy link
Member Author

This is required for #2532

@MinnDevelopment MinnDevelopment marked this pull request as draft November 18, 2023 18:55
@RedDaedalus
Copy link
Contributor

It would be ideal if this were configurable to some degree -- newer features will be gated to later minimum app versions.

@MinnDevelopment
Copy link
Member Author

It would be ideal if this were configurable to some degree -- newer features will be gated to later minimum app versions.

Headers can already be customized with setRestConfig by setting a custom builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld Awaiting requested review from DV8FromTheWorld

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MinnDevelopment @RedDaedalus