Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SelectMenus in Modals #2162

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Xirado
Copy link
Contributor

@Xirado Xirado commented Jun 23, 2022

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2161

Description

Adds support for SelectMenus in Modals.

Disclaimer: This is not yet documented by Discord.

@Xirado Xirado marked this pull request as ready for review June 23, 2022 09:16
Marcel Korzonek and others added 4 commits June 24, 2022 20:48
Marcel Korzonek and others added 3 commits June 24, 2022 22:31
@MinnDevelopment
Copy link
Member

@seailz you can use the current PR through jitpack. This is explained in our wiki.

Please only use the comments of pull requests for discussion of the implementation and feedback.

@seailz
Copy link
Contributor

seailz commented Jul 4, 2022

@seailz you can use the current PR through jitpack. This is explained in our wiki.

Yeah just waiting for it to be merged & for discord's doc

Please only use the comments of pull requests for discussion of the implementation and feedback.

Sorry about that

@seailz seailz mentioned this pull request Jul 4, 2022
@seailz

This comment was marked as resolved.

@freya022

This comment was marked as resolved.

@seailz

This comment was marked as resolved.

@LucGamesYT
Copy link

Any new information when this will be ready ?

@Xirado
Copy link
Contributor Author

Xirado commented Aug 4, 2022

Any new information when this will be ready ?

This feature is not even released by Discord, it only works on Desktop, and is not documented. See this link if you still want to use it.

@CreaCloudz
Copy link

hasn't worked for 2 hours

@MinnDevelopment
Copy link
Member

@CreaCloudz Discord blocks you from using it because its not released.

@CreaCloudz
Copy link

@CreaCloudz Discord blocks you from using it because its not released.

Not exactly seeing that it still works in JS

@Xirado
Copy link
Contributor Author

Xirado commented Aug 18, 2022

@CreaCloudz Discord blocks you from using it because its not released.

Not exactly seeing that it still works in JS

no it doesn't

@DV8FromTheWorld
Copy link
Member

Discord restricted access to Selects in Modals because people were using them before they were ready to be released and breaking mobile experiences for users and causing Discord to catch flack from confused bot devs and frustrated users.

Essentially, Discord's hand was forced because people were using an unreleased feature before it was ready.

@CreaCloudz
Copy link

Discord restricted access to Selects in Modals because people were using them before they were ready to be released and breaking mobile experiences for users and causing Discord to catch flack from confused bot devs and frustrated users.

Essentially, Discord's hand was forced because people were using an unreleased feature before it was ready.

Thanks for the info, hope he adds it soon.

@DV8FromTheWorld DV8FromTheWorld added the status: freezer this is currently put on hold label Sep 11, 2022
@DV8FromTheWorld
Copy link
Member

Frozen until the feature is actually functional again.

@MinnDevelopment
Copy link
Member

This PR will be updated when there are news. No need to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants