Rollback commonjs plugin in extensions-sdk to fix minified builds #17539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekrai
requested review from
paescuj,
a team,
connorwinston and
jaads
and removed request for
a team
paescuj
force-pushed
the
fix/extensions-sdk-rollup-terser-rollback
branch
from
37c79ec
to
1aa13c9
Compare
paescuj
changed the title
rijkvanzanten
approved these changes
Feb 16, 2023
paescuj
approved these changes
Feb 16, 2023
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
Mar 3, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Merged
ThinkZ
pushed a commit
to ThinkZ/directus-view
that referenced
this pull request
Mar 29, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rollup commonjs plugin breaks builds when minified (must be a combination issue with the terser as it works when not minified) from version 23.0.5 (pull request rollup/plugins#1363).
Therefore we rollback to version 23.0.4 for now, where minified builds work without any problems.
Fixes #17529
Type of Change
Requirements Checklist
If adding a new feature: