Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Favicon when project color and logo are not set #14666

Merged
merged 1 commit into from Jul 26, 2022
Merged

Fix Favicon when project color and logo are not set #14666

merged 1 commit into from Jul 26, 2022

Conversation

nickrum
Copy link
Member

@nickrum nickrum commented Jul 26, 2022

Description

Small workaround for vuejs/core#5032.

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@nickrum nickrum added this to the Next Release milestone Jul 26, 2022
@rijkvanzanten rijkvanzanten merged commit ceff32f into main Jul 26, 2022
@rijkvanzanten rijkvanzanten deleted the fix/default-favicon branch July 26, 2022 15:06
qborisb pushed a commit to qborisb/directus that referenced this pull request Jul 28, 2022
@nickrum @qborisb
Fix Favicon when project color and logo are not set (directus#14666)
da6a80f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees
No one assigned
Labels
🍰 Bug
Projects
None yet
Milestone
v9.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickrum @rijkvanzanten