Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Closed* to Closed*Assign and introduce non-Assign Closed* traits #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename Closed* to Closed*Assign and introduce non-Assign Closed* traits #5

wants to merge 1 commit into from

Conversation

z33ky
Copy link

@z33ky z33ky commented Jun 14, 2020

As per suggestion in nalgebra#728.

@sebcrozet sebcrozet added breaking change This is a breaking change that will result in a major version bump. enhancement New feature or request labels Jun 14, 2020
@sebcrozet
Copy link
Member

Thanks! It looks like the CI does not accept the formatting. Did you run a cargo fmt (using a stable version of the compiler because the nightly version does not give the same results)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change This is a breaking change that will result in a major version bump. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@z33ky @sebcrozet