Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contiguous arena add remove test #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rezural
Copy link
Contributor

@rezural rezural commented Sep 29, 2021

This adds a test to ContiguousArena to add & remove. This test fails on master.

I'm not sure how to safely fix this, as I'm not too sure what this struct is doing, but the following fixes the panic:

        if let Some(rev_id) = swapped_rev_id {
            if let Some(indice) = self.indices.get_mut(rev_id) {
                *indice = i;
            }
        }

@rezural rezural force-pushed the contiguous-arena-add-remove-test branch from 52f24ce to 6d59978 Compare September 29, 2021 03:24
@rezural rezural closed this Sep 29, 2021
@rezural rezural force-pushed the contiguous-arena-add-remove-test branch from 6d59978 to 09de9d4 Compare September 29, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant