impl PartialEq for Shapes, and SharedShape #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
derive(PartialEq)to Shapes that were missing them, where possible.implemented eq tests for some other shapes.
not sure how to compare heightfields correctly, so that is just false at the moment.
also custom shape type just returns false.
not sure if it's feasible to add
PartialEqto theShapetrait bounds. I tried, and it complained due to it being used as a trait object. Perhaps this is possible, and there's a way to remove the big match statement?Would love a review and advice on what to do about custom/heightfield.
Thanks!
see #51