Transcendentals2 #554
Closed
Transcendentals2 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebcrozet
requested changes
Feb 23, 2019
There was a problem hiding this comment.
Thank you for this PR!
The sinc and sinhc functions should be added to the alga crate, as part of the Real trait (with those implementations given as the default one). For completeness, cosc and coshc should be added too.
| #[inline] | ||
| fn sinc<N: Real>(v: N) -> N { | ||
| if v == N::zero() { | ||
| N::zero() |
There was a problem hiding this comment.
Suggested change
| N::zero() | |
| N::one() |
| #[inline] | ||
| fn sinhc<N: Real>(v: N) -> N { | ||
| if v == N::zero() { | ||
| N::zero() |
There was a problem hiding this comment.
Suggested change
| N::zero() | |
| N::one() |
| @@ -506,6 +527,22 @@ impl<N: Real> Quaternion<N> { | |||
| pub fn normalize_mut(&mut self) -> N { | |||
| self.coords.normalize_mut() | |||
| } | |||
|
|
|||
| /// Calculates quaternionic sin | |||
There was a problem hiding this comment.
Suggested change
| /// Calculates quaternionic sin | |
| /// Calculates the quaternionic cosinus. |
| Self::from_parts(self.w.cos() * z.cosh(), self.imag() * w) | ||
| } | ||
|
|
||
| /// Calculates quaternionic sin |
There was a problem hiding this comment.
Suggested change
| /// Calculates quaternionic sin | |
| /// Calculates the quaternionic sinus. |
There was a problem hiding this comment.
I think "sine" and "cosine" are the most common spellings of these in English.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #551, adds sin and cos. Implementations are based on the boost implementation
https://www.boost.org/doc/libs/1_63_0/boost/math/quaternion.hpp