Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Glam 0.25 type conversion #1357

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Support Glam 0.25 type conversion #1357

merged 1 commit into from
Feb 14, 2024

Conversation

Jondolf
Copy link
Contributor

@Jondolf Jondolf commented Jan 27, 2024

Glam was updated to 0.25 a few weeks ago, so this PR adds type conversion for it through the glam-0.25 feature. This will be needed for migrating e.g. Bevy physics engines to Bevy 0.13 once it is released.

Let me know if I missed something I need to update!

@tpdickso
Copy link
Collaborator

Thank you for the contribution! LGTM.

@tpdickso
Copy link
Collaborator

@Ralith @Andlon Sorry for the direct ping -- this looks like an easy PR to merge, but test-nalgebra appears to be flaky (I've run it twice and it failed on a proptest of two different items.) I was able to pull the commit and run the tests locally and they pass fine. Do you know if this flake rate is expected, and would it be alright to merge in this state, or is there something I should dig into to address it?

@Ralith
Copy link
Collaborator

Ralith commented Feb 14, 2024

Proptest is randomized, right? "Flakes" from it are probably real errors, or at least buggy tests, then. If the tests are related to the changes in this PR, then they should block; otherwise, open an issue for them but don't treat them as blocking for this PR.

@tpdickso
Copy link
Collaborator

tpdickso commented Feb 14, 2024

The changes are fully unrelated, so shouldn't be blocking. I'll open an issue. I think the proptests may just have had too tight a tolerance.

However, I will say that despite copying the command out of CI verbatim, the CI run lists 510 passed; 1 failed; while mine lists 505 passed; 2 ignored; -- I'm using the commit from this PR and my working directory is clean, so maybe it's OS-based conditional compilation or similar.

@tpdickso tpdickso merged commit ee48679 into dimforge:dev Feb 14, 2024
10 of 11 checks passed
@Jondolf Jondolf deleted the glam025 branch February 14, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants