Allow multiplying matrix by Complex<> on the left
#1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpdickso
force-pushed
the
dev_left_multiply_complex
branch
from
c95cef8
to
b71a0c4
Compare
This simply inserts `Complex<f32>` and `Complex<f64>` into the `left_scalar_mul_impl!` macro alongside the primitives' trait impls.
tpdickso
force-pushed
the
dev_left_multiply_complex
branch
from
b71a0c4
to
e5ec825
Compare
|
I think it would be good to have some very basic tests that verify that it indeed does work in some basic cases. I think just verifying that an arbitrary complex number multipled with an arbitrary matrix gives expected results should be enough, I can't imagine that much could go wrong here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply inserts
Complex<f32>andComplex<f64>into theleft_scalar_mul_impl!macro alongside the primitives' trait impls.