Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Point display to respect formatting parameters #1116

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix Point display to respect formatting parameters #1116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9036e87
Fix Point display to respect formatting parameters
owenbrooks Jun 6, 2022
e18636f
Forward point formatting through to underlying vector
owenbrooks Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/geometry/point.rs
View file
Open in desktop
Expand Up @@ -458,16 +458,8 @@ where
DefaultAllocator: Allocator<T, D>,
{
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "{{")?;

let mut it = self.coords.iter();

write!(f, "{}", *it.next().unwrap())?;

for comp in it {
write!(f, ", {}", *comp)?;
}

write!(f, "Point {{")?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather omit this wrapping for concision, personally. It's also unconventional for Display impls in general.

self.coords.fmt(f)?;
write!(f, "}}")
}
}