Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take-2 of polar-decomposition #1050

Merged
merged 9 commits into from Dec 31, 2021
Merged

Take-2 of polar-decomposition #1050

merged 9 commits into from Dec 31, 2021

Commits on Dec 22, 2021

  1. First compiling commit for take-2 of polar-decomposition: 

    Code inspired by this thread: dimforge#656
Main person behind this is LucasCampos
    metric-space committed Dec 22, 2021
    Copy the full SHA
    6ac6e7f View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Add polar decomposition method to main matrix decomposition interface 

    Add one more test for decomposition of polar decomposition of rectangular matrix
    metric-space committed Dec 27, 2021
    Copy the full SHA
    ac94fbe View commit details
    Browse the repository at this point in the history

  2. Fix doc typos

    metric-space committed Dec 27, 2021
    Copy the full SHA
    dbaefed View commit details
    Browse the repository at this point in the history

  3. Increased strength of tests for polar decomposition

    metric-space committed Dec 27, 2021
    Copy the full SHA
    43c1f8f View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Add Matrix::try_polar that returns Option and make Matrix::polar not … 

    …return Option
    @sebcrozet
    sebcrozet committed Dec 30, 2021
    Copy the full SHA
    cc10b67 View commit details
    Browse the repository at this point in the history

  2. Use proptest for testing the polar decomposition

    @sebcrozet
    sebcrozet committed Dec 30, 2021
    Copy the full SHA
    8e0ca43 View commit details
    Browse the repository at this point in the history

  3. Test: minor style fix

    @sebcrozet
    sebcrozet committed Dec 30, 2021
    Copy the full SHA
    67a82c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Change svd to svd_unordered for the method output to be equal 

    Comment out unitary check for now
    metric-space committed Dec 31, 2021
    Copy the full SHA
    ae6fda7 View commit details
    Browse the repository at this point in the history

  2. Semi-unitary test checks for if rows or cols are orthonomal

    metric-space committed Dec 31, 2021
    Copy the full SHA
    498d7e3 View commit details
    Browse the repository at this point in the history