New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sparse] Add clear_triplets()
#1141
Conversation
Thanks for working on this @lsh! Actually, I suggested |
@Andlon whoops, sorry about my misunderstanding 😅. Updated the code to implement |
@lsh: great, thanks. CI is failing because you have the wrong return type for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsh: just one unnecessary trait bound that needs to be removed, otherwise looks good! Tests are still running but assuming they succeed after removing the trait bound we should be good to go.
@sebcrozet: not sure why the CUDA build is failing. Do you? Looks like some strange issues with the recent changes that made |
@Andlon You’re right, looks like #1112 broke the CUDA build (and for some reasons the CI didn’t run of that PR). I think this is due to the fact that the CUDA build uses an older version of the compiler which only allowed |
Looks good to me, ready for merge. @sebcrozet: do we wait with merging until the CUDA CI problems are fixed, or what's your preference? |
Thank you both! No need to delay this on something unrelated. |
This PR adds the
clear_triplet()
method to theCooMatrix
struct.The goal of the method is to be able to remove triplets before construction.
Some outstanding questions:
clear_triplet
in the Discord. Another option might bepop
orpop_triplet
to correspond topush
.None
value.Option<T>
.