Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails in the build-cuda step #1155

Closed
patowen opened this issue Sep 24, 2022 · 2 comments · Fixed by #1156
Closed

CI fails in the build-cuda step #1155

patowen opened this issue Sep 24, 2022 · 2 comments · Fixed by #1156

Comments

@patowen
Copy link
Contributor

patowen commented Sep 24, 2022

The CI process currently fails every PR in the build-cuda step due to the changes in #1112. I believe there are multiple ways to fix this:

  • Use the latest nightly version instead of a specific version when building for CUDA
  • Update the Rust nightly version (much like what was done in 229c137)
  • Use the latest Rust stable version instead of nightly (I haven't researched if this is possible, and I expect it's not)
  • Revert Make "Point::new" a const fn #1112 (not the ideal solution)
  • Add a non-const version specifically for targeting CUDA, probably using the cfg attribute (as suggested in [Sparse] Add clear_triplets() #1141 (comment))

I believe the code to modify is at

- name: Install nightly-2021-12-04
uses: actions-rs/toolchain@v1
with:
toolchain: nightly-2021-12-04
override: true

I would create a PR, but I don't have enough context to know which bullet point is preferred.

@sebcrozet
Copy link
Member

Hi! I’ll take care of this in #1156. We can’t use stable or update the nigthly version because rust-cuda requires a specific version of the compiler. The clean fix would be to revert Point::new being const, but it feels unfortunate to remove this for everybody where it’s only really an issue when using cuda.

So let’s just add a non-const version behind a cfg feature flag. This does go against the additive nature of cargo features, but I think it’s fine for now.

@patowen
Copy link
Contributor Author

patowen commented Sep 24, 2022

Oh, got it. This limitation is clearly written at https://github.com/Rust-GPU/Rust-CUDA/blob/master/guide/src/guide/getting_started.md#rust-toolchain. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants