Send bytestrings to sumo #19825
Merged
Send bytestrings to sumo #19825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,11 +198,11 @@ def _get_header(self, fmt): | |||
| if settings.SERVER_ENVIRONMENT == 'production': | |||
| environment = 'prod' | |||
|
|
|||
| return {"X-Sumo-Category": "{env}/{domain}/{fmt}".format( | |||
| return {str("X-Sumo-Category"): "{env}/{domain}/{fmt}".format( | |||
There was a problem hiding this comment.
I think you want b"X-Sumo-Category" here, right?
dannyroberts
approved these changes
Mar 15, 2018
|
fyi @nickpell |
|
@emord will you let me know whenever you do an ICDS deploy next? I want to confirm that this fixed things |
|
@amstone326 @snopoke is going to kick one off tonight after maintenance |
|
Great, thanks!
…On Fri, Mar 16, 2018 at 8:57 AM, Jonathan Emord ***@***.***> wrote:
@amstone326 <https://github.com/amstone326> @snopoke
<https://github.com/snopoke> is going to kick one off tonight after
maintenance
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19825 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjPh0pxh70kJm3jJXuKWM3BmdFgIrgkks5te7aqgaJpZM4Ssp3b>
.
--
Aliza Stone
Mobile Engineer
Dimagi, Inc.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started getting: https://sentry.io/dimagi/commcarehq/issues/493068892/ after #19786 was merged. That PR inadvertently changed our headers to be unicode, instead of bytestrings.
This issue tedder/requests-aws4auth#24 seems to suggest that that can cause urllib3 to do funny things when we are sending large POST requests using the
requestslibrary.FYI @amstone326