Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rand v0.8 #23

Closed
alechenthorne opened this issue Jan 19, 2021 · 7 comments
Closed

Support for Rand v0.8 #23

alechenthorne opened this issue Jan 19, 2021 · 7 comments

Comments

@alechenthorne
Copy link

Simply upgrading the dependency to Rand v0.8 doesn't work as it seems the rand::AsBytesSliceMut trait has been removed and more info can be seen in this comment.

This requires for gen_biguint to move to using the higher level fill method rather than the fill_bytes method on the data.

I have a working example, but would be curious the thoughts on using fill directly.

@phayes
Copy link

phayes commented Feb 15, 2021

I have a PR for this here: #25

@dignifiedquire
Copy link
Owner

Still waiting a little bit longer to propagate this through libraries, breaking rand changes are quite painful and dividing in the ecosystem. Last time around it took months for the ecosystem to rally behind the latest version.

@phayes
Copy link

phayes commented Feb 20, 2021

One approach could be to track a separate alpha branch that contains the updated rand as an interim measure. It looks like this is the approach that the dalek-cryptography folks will be taking (dalek-cryptography/curve25519-dalek#338). It's worth noting that curve25519 is related to num-bigint-dig via num-bigint-dig <- pgp -> ed25519-dalek -> curve25519-dalek.

@dignifiedquire
Copy link
Owner

I don't think I'll want an extra release cycle, I'll probably merge it soonish to master and then do a release once things are looking good.

@sabify
Copy link

sabify commented Mar 7, 2021

@dignifiedquire Would you mind to release the update for crate.io due to latest changes for support rand 0.8?

@dignifiedquire
Copy link
Owner

Released 0.7 with rand@0.8 support

@sabify
Copy link

sabify commented Mar 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants