Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsa is not compatible with rand 0.8.0 #81

Closed
brmmm3 opened this issue Jan 4, 2021 · 5 comments · Fixed by #88
Closed

rsa is not compatible with rand 0.8.0 #81

brmmm3 opened this issue Jan 4, 2021 · 5 comments · Fixed by #88

Comments

@brmmm3
Copy link

brmmm3 commented Jan 4, 2021

If I update my dependency of rand from 0.7.3 to 0.8.0 I get the following error:

the trait bound rand::rngs::OsRng: rand_core::RngCore is not satisfied the trait rand_core::RngCore is not implemented for rand::rngs::OsRng note: required because of the requirements on the impl of rand::Rng for rand::rngs::OsRng

I'm using rsa 0.3.0.

@alechenthorne
Copy link

This seems to require that num-bigint is updated to rand 0.8 first and I've added an issue in that project.

@dignifiedquire
Copy link
Member

Still waiting a little bit longer to propagate this through libraries, breaking rand changes are quite painful and dividing in the ecosystem. Last time around it took months for the ecosystem to rally behind the latest version.

@phayes
Copy link
Contributor

phayes commented Feb 19, 2021

PR is here: #85 , requires upstream PR to be merged first.

@tarcieri
Copy link
Member

We'll be bumping (most of) the rest of the RustCrypto to use rand_core v0.6 later this month / early next month so it's probably a good time to upgrade.

Definitely agree these are really painful upgrades, especially as rand is the most used crate in the entire Rust ecosystem, according to the "Most Downloaded" list on https://crates.io/

@littledivy
Copy link
Contributor

littledivy commented Mar 6, 2021

rand 0.8 support was added to num-bigint 0.4.0 so #85 is no longer blocked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants