-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VPC-3361] Add VPC Peering resource #1160
Merged
danaelhe
merged 40 commits into
digitalocean:main
from
apinonformoso:apinonformoso/vpc-peering
May 28, 2024
Merged
[VPC-3361] Add VPC Peering resource #1160
danaelhe
merged 40 commits into
digitalocean:main
from
apinonformoso:apinonformoso/vpc-peering
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddatta-do
reviewed
May 20, 2024
apinonformoso
force-pushed
the
apinonformoso/vpc-peering
branch
from
May 20, 2024 19:39
d06c85e
to
e83804a
Compare
ddatta-do
reviewed
May 21, 2024
…terraform-provider-digitalocean into apinonformoso/vpc-peering
ddatta-do
reviewed
May 21, 2024
ddatta-do
approved these changes
May 21, 2024
lfundaro-do
reviewed
May 22, 2024
danaelhe
reviewed
May 28, 2024
danaelhe
reviewed
May 28, 2024
danaelhe
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nitpick on minor change on naming- but looks good!
Super small request 🤏 Could you also change the filenames to be |
danaelhe
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPC Peering is a closed beta feature and not available for public use.
Testing doc