Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VPC-3361] Add VPC Peering resource #1160

Merged
merged 40 commits into from
May 28, 2024

Conversation

apinonformoso
Copy link
Contributor

VPC Peering is a closed beta feature and not available for public use.

Testing doc

digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/datasource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/import_vpcpeeirng_test.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/sweep.go Show resolved Hide resolved
digitalocean/vpcpeering/sweep.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering.go Outdated Show resolved Hide resolved
digitalocean/vpcpeering/resource_vpcpeering_test.go Outdated Show resolved Hide resolved
@apinonformoso apinonformoso marked this pull request as ready for review May 21, 2024 16:07
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick on minor change on naming- but looks good!

@danaelhe
Copy link
Member

Super small request 🤏 Could you also change the filenames to be vpc_peering as well?

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@danaelhe danaelhe merged commit 066bfa5 into digitalocean:main May 28, 2024
3 checks passed
@apinonformoso apinonformoso deleted the apinonformoso/vpc-peering branch May 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants