Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent PRs such as #1155 , we were getting
Error: golangci-lint exit with code 7
with theLint with golangci-lint
step in the CI. I was able to reproduce the issue locally:Turns out it's a mix match of go version
1.21
and the version of golangci being used. Need to update go version to1.22.x
in the pipeline and stickgolangci
to versionv1.56.2
in the makefile. This allowed a successful run locally: