Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-8386: Add comments to mark deprecation of unused instance size fields #686

Merged

Conversation

greeshmapill
Copy link
Contributor

@greeshmapill greeshmapill commented May 6, 2024

Update comments for fields that have been marked deprecated in apps.proto.

@greeshmapill greeshmapill changed the title APPS-8386: Add comments to mark deprecation for unused instance size … APPS-8386: Add comments to mark deprecation for unused instance size fields May 6, 2024
@greeshmapill greeshmapill force-pushed the APPS-8386-comment-deprecated branch from f47844d to 70d0714 Compare May 7, 2024 10:20
@greeshmapill greeshmapill changed the title APPS-8386: Add comments to mark deprecation for unused instance size fields APPS-8386: Add comments to mark deprecation of unused instance size fields May 7, 2024
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danaelhe danaelhe merged commit 4adfcf8 into digitalocean:main May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants