Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListDatabaseEvents to Godo #675

Merged

Conversation

bhardwajRahul
Copy link
Member

@bhardwajRahul bhardwajRahul commented Apr 1, 2024

This PR adds support for Project Events:

GET on /v2/databases/<database_id>/events via Databases.ListProjectEvents - lists all of the cluster events.

For details: https://docs.digitalocean.com/reference/api/api-reference/#operation/databases_list_events_logs

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhardwajRahul This looks great! I do have one question though:

I'm curious why we are calling the method and type ProjectEvent? We don't really seem to use the word "project" in connection with DBaaS clusters anywhere else (e.g. control panel or docs). I wonder if DatabaseEvent might be a bit more consistent with the rest of the naming?

@bhardwajRahul
Copy link
Member Author

@bhardwajRahul This looks great! I do have one question though:

I'm curious why we are calling the method and type ProjectEvent? We don't really seem to use the word "project" in connection with DBaaS clusters anywhere else (e.g. control panel or docs). I wonder if DatabaseEvent might be a bit more consistent with the rest of the naming?

Yup, I agree DatabaseEvent would be more appropriate.

@bhardwajRahul bhardwajRahul changed the title Add ListProjectEvents to Godo Add ListDatabaseEvents to Godo Apr 3, 2024
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks

@andrewsomething andrewsomething merged commit c56902f into digitalocean:main Apr 4, 2024
8 checks passed
@bhardwajRahul bhardwajRahul deleted the rbhardwaj/DBAAS-4764 branch April 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants