Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: Add registry_credentials field, GHCR registry type and the egress spec #657

Merged
merged 1 commit into from
Nov 28, 2023
Merged

apps: Add registry_credentials field, GHCR registry type and the egress spec #657

merged 1 commit into from
Nov 28, 2023

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Nov 28, 2023 •
edited

As per title.

Please don't merge yet. The production code isn't fully rolled out yet.

It's in prod now!

ZachEddy
ZachEddy approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ZachEddy ZachEddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Egress spec changes LGTM.

danaelhe
danaelhe approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danaelhe danaelhe merged commit a1fd6a5 into digitalocean:main Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachEddy ZachEddy ZachEddy approved these changes

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markusthoemmes @ZachEddy @danaelhe