Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use fmt.Fprintf instead of fmt.Fprintf(fmt.Sprintf(...)) #648

Merged
merged 2 commits into from
Oct 23, 2023
Merged

test: use fmt.Fprintf instead of fmt.Fprintf(fmt.Sprintf(...)) #648

merged 2 commits into from
Oct 23, 2023

Conversation

alexandear
Copy link
Contributor

This PR makes the same changes as #621. Additionally, replace string(resp) with resp because fmt.Sprintf("%s", string(resp)) is the same as fmt.Sprintf("%s", resp) when resp has the []byte type.

andrewsomething
andrewsomething approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@andrewsomething andrewsomething merged commit 39cdba9 into digitalocean:main Oct 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @andrewsomething