Allow configuring go-retryablehttp.Logger #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
commented
Aug 14, 2023
| @@ -307,6 +308,9 @@ func New(httpClient *http.Client, opts ...ClientOpt) (*Client, error) { | |||
| retryableClient.RetryWaitMax = time.Duration(*c.RetryConfig.RetryWaitMax * float64(time.Second)) | |||
| } | |||
|
|
|||
| // By default this is nil and does not log. | |||
There was a problem hiding this comment.
This is handled in go-retryablehttp here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, godo has not done any logging on its own. When using the new
WithRetryAndBackoffsoption, this is no longer the case. When used, each request is logged to stderr. This is surprising and not always desirable (e.g. for a cli tool like doctl).This PR exposes the
go-retryablehttp.Loggeroption in theRetryConfig. It defaults tonilto prevent logging as this matches the historical behavior. A logger can be configured as knowing when/if a request is being retried is useful.