Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbuser: add events to db user custom resource #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dbuser: add events to db user custom resource #33

wants to merge 1 commit into from

Conversation

varshavaradarajan
Copy link
Contributor

TODO:

  • Test event generation on a plugin enabled ccp cluster.

varshavaradarajan
varshavaradarajan commented Oct 19, 2022
View reviewed changes
controllers/databaseuser_controller.go
@@ -94,8 +98,10 @@ func (r *DatabaseUserReconciler) Reconcile(ctx context.Context, req ctrl.Request

if len(errs) == 0 {
if updated {
r.Recorder.Event(&user, corev1.EventTypeNormal, "Updated", "database user update succeeded")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the reason should be DBUser specific or should follow k8s conventions as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwg adamwg Awaiting requested review from adamwg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@varshavaradarajan