Add new annotation for using certificate name when configuring load balancer TLS #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
reviewed
May 16, 2024
bbassingthwaite
force-pushed
the
bbass/LBAAS-3246/support-certificate-name
branch
from
04ae381
to
b891e2b
Compare
timoreimann
approved these changes
May 27, 2024
…alancer TLS This will improve the users experience when using a certificate. A name is easier to identify then a UUID. If they are using lets encrypt, the underlying UUID will change on each renewal which causes headaches for users. Certificate names are also now unique so we can identify a certificate by its name even if the underlying UUID has changed.
bbassingthwaite
force-pushed
the
bbass/LBAAS-3246/support-certificate-name
branch
from
b891e2b
to
cf28ba5
Compare
|
Fixes #573. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the users experience when using a certificate. A name is easier to identify then a UUID. If they are using lets encrypt, the underlying UUID will change on each renewal which causes headaches for users. Certificate names are also now unique so we can identify a certificate by its name even if the underlying UUID has changed.
The existing certificate ID annotation will take precedence. If they specify a name, we will use the certificate API to look it up and get the certificate ID.