Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to fix crash on Go 1.17 #126

Merged
merged 2 commits into from Sep 19, 2021
Merged

Update dependencies to fix crash on Go 1.17 #126

merged 2 commits into from Sep 19, 2021

Commits on Sep 19, 2021

  1. Update dependencies to fix crash on Go 1.17 

    When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

Also bump the minimum (library) dependency to 1.16 in go.mod since that
is the oldest, officially supported Go version. Bumping to 1.17 actually
enables us to fix the issue by simply updating to the latest
github.com/fatih/color, as opposed to adding an indirect import of
github.com/mattn/go-isatty which this change does right now (which I
suppose works due to Go 1.17 module management improvements); however,
that'd come at the price of breaking compatibility with 1.16 users which
is non-ideal.
Regardless, update github.com/fatih/color as well while we're here.

Also bump the version of the Go image used for testing.

[1] mattn/go-isatty#66
    @timoreimann
    timoreimann committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    b90371a View commit details
    Browse the repository at this point in the history

  2. Add smoke-test

    @timoreimann
    timoreimann committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    92d914f View commit details
    Browse the repository at this point in the history