Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pylint for more files #34

Merged
merged 2 commits into from Apr 21, 2023
Merged

Enable pylint for more files #34

merged 2 commits into from Apr 21, 2023

Conversation

timobrembeck
Copy link
Member

@timobrembeck timobrembeck commented Apr 20, 2023 •
edited

Short description

Enable pylint for more files.
Unfortunately, pylint is not able to disable specific warnings for entire directories (see pylint-dev/pylint#618), so I added the plugin https://github.com/christopherpickering/pylint-per-file-ignores

Proposed changes

  • Enable pylint for tests directory (but disable unused-argument and missing-function-docstring)
  • Enable pylint for integreat-compass-cli

@timobrembeck timobrembeck requested a review from a team as a code owner April 20, 2023 10:51
@timobrembeck timobrembeck mentioned this pull request Apr 20, 2023
Merged
charludo
charludo approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems to work without problems.

@timobrembeck timobrembeck merged commit 3413706 into develop Apr 21, 2023
1 check passed
@timobrembeck timobrembeck deleted the pylint-more-files branch April 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charludo charludo charludo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timobrembeck @charludo