-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch and handle errors of FCM #2805
Conversation
Code Climate has analyzed commit b19104e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 15.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.2% (0.0% change). View more on Code Climate. |
900953e
to
d1f3ada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this fixes both linked issues.
I think, as part of the clean code initiative, we should avoid introducing new pylint: disable=
comments. Maybe one option would be to handle the errors directly at self.send_pn
f678e73
to
fca36f0
Compare
@david-venhoff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this extra handling 👍
fca36f0
to
b19104e
Compare
Short description
This PR add an error handling for invalid FCM URL.
update
This takes care of timeout exception too. I've totally forgotten that those two issues are related each other.
Proposed changes
Side effects
Resolved issues
Fixes: #2025 , #2790
Pull Request Review Guidelines