deps: update protobuf #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
protobuf
branch
2 times, most recently
from
c42bf9e
to
ef8efcd
Compare
Beerosagos
reviewed
Aug 16, 2022
README.md
Outdated
| Make sure you have `protoc` and | ||
| [protoc-gen-go](https://developers.google.com/protocol-buffers/docs/reference/go-generated) | ||
| installed: | ||
|
|
||
| `git clone https://github.com/digitalbitbox/bitbox02-firmware.git` | ||
|
|
||
| ```sh | ||
| rm -rf api/firmware/messages/* |
There was a problem hiding this comment.
This removes also generate.sh. I would suggest to use rm -rf api/firmware/messages/*.proto and rm -rf api/firmware/messages/*.go or to move generate.sh in another folder
The module we used previouly, github.com/golang/protobuf/proto, is deprecated. See https://github.com/golang/protobuf/releases/tag/v1.5.2 and golang/protobuf#1306. We use the official succssor: ``` (fix imports) go get google.golang.org/protobuf/proto@v1.28.1 go mod tidy ``` The .pb.go generated files also needed to be updated with an updated protoc-gen-go: ``` go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28.1 ``` A new script was added to generate the files, as the `import_path=messages` flag seems to be removed in favour of the `M` flag, which unfortunately has to be specified for each .proto file :( ----------- In `BTCSign()`, the inputs are not copied anymore due to: ``` api/firmware/btc.go:300:20: cannot use &input (value of type **messages.BTCSignInputRequest) as *messages.BTCSignInputRequest value in struct literal (typecheck) BtcSignInput: &input, ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module we used previouly, github.com/golang/protobuf/proto, is
deprecated. See https://github.com/golang/protobuf/releases/tag/v1.5.2
and golang/protobuf#1306.
We use the official succssor:
The .pb.go generated files also needed to be updated with an updated
protoc-gen-go:
A new script was added to generate the files, as the
import_path=messagesflag seems to be removed in favour of theMflag, which unfortunately has to be specified for each .proto file :(