Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to codecov v4. #177

Merged
merged 1 commit into from May 14, 2024
Merged

Update github actions to codecov v4. #177

merged 1 commit into from May 14, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Apr 29, 2024

not sure if the codecov token is set.

@aljones15 aljones15 self-assigned this Apr 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (4cd1f8e) to head (20aa72d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           4        4           
  Lines         811      811           
=======================================
  Hits          720      720           
  Misses         91       91           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd1f8e...20aa72d. Read the comment docs.

@davidlehn
Copy link
Member

  • The same thing is in update-vc-2.0 already. Does it need to be in main as well?
  • It's an org level secret so should work with all repos.

@aljones15
Copy link
Contributor Author

aljones15 commented Apr 29, 2024

  • The same thing is in update-vc-2.0 already. Does it need to be in main as well?
  • It's an org level secret so should work with all repos.

We don't know when update-vc-2.0 will hit main so yeah I think it's better to do it here and not further clog up the update-vc-2.0 PR. p.s. I didn't know it was also in upgrade-vc-2.0

@davidlehn
Copy link
Member

It's not really clogging up anything. But feel free to merge. I think dave's commit in the other branch will get dropped on a rebase.

@aljones15 aljones15 merged commit f7cf40c into main May 14, 2024
5 checks passed
@aljones15 aljones15 deleted the update-code-cov branch May 14, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants