-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set env 2022 #57
Set env 2022 #57
Conversation
Using eslint 8 needs to be tested against existing modules like |
looks like |
This should be addressed sooner rather than later.
|
I think the best action here is to comment out the If we set env.2022=true, then ecmaVersion is set to 13 (2022). Does it make sense to set ecmaVersion here at all? Proposed update in #58. |
Seems like we should close this in favor of #58. |
Closing in favor of #58 |
Reopening to cascade the other branch through here. |
Disable `jsdoc/check-examples` until eslint 8 related issue is fixed. eslint/eslint#14745
`env.es2022=true` automatically sets `ecmaVersion` to `13` (2022). It seems better to keep parsing mode and globals in sync with the `env` setting rather than getting a newer `ecmaVersion` without other related support.
This removes the need to set
ecmaVersion
while also updating the globals that eslint thinks are ok.