Mongodb driver v6 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcollier
requested review from
dlongley,
aljones15,
JSAssassin and
mandyvenables
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 7 7
Lines 946 946
=======================================
Hits 896 896
Misses 50 50
Continue to review full report in Codecov by Sentry.
|
dlongley
approved these changes
Dec 15, 2023
| @@ -58,7 +58,7 @@ export async function generateKey({ | |||
| key | |||
| }; | |||
| try { | |||
| await database.collections.ssm.insertOne(record, database.writeOptions); | |||
| await database.collections.ssm.insertOne(record); | |||
There was a problem hiding this comment.
Nice, looks like inserts here didn't really need much adjusting.
mandyvenables
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merge/release:
test/.npmrcfile