Fix DAML_SDK_VERSION causing a network lookup #19231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18271) * Add resolution via artifactory, handle HTTP errors * Replace origin with wrapErr in resolveReleaseVersionUnsafe * Handle broken connections (e.g. no internet) * drop comment, fix foldMap id to fold * remove debugging writeFile calls run-all-tests: true * Rename partial field damlPath to damlPathUnsafe and add safe function * support multiple possible installation locations * update alternatives * Wrap CouldNotResolveReleaseVersion into AssistantError in unsafe resolve
moisesackerman-da
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the env var DAML_SDK_VERSION is set, a network lookup is triggered. Now, we defer this lookup only to places where it's necessary.
We also backport split release artifactory support to 2.x