make LF 1.16 stable #19230
Merged
make LF 1.16 stable #19230
+125
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgugliel-da
reviewed
May 17, 2024
| @@ -291,7 +297,6 @@ class TransactionSpec | |||
| val parties = Set("Alice") | |||
|
|
|||
| def create(s: V.ContractId) = { | |||
| println(s) | |||
dylant-da
approved these changes
May 21, 2024
| @@ -72,7 +74,7 @@ trait TestNodeBuilder { | |||
|
|
|||
| Node.Create( | |||
| coid = id, | |||
| packageName = packageName.filter(_ => transactionVersion < TransactionVersion.minUpgrade), | |||
| packageName = packageName.filter(_ => transactionVersion >= TransactionVersion.minUpgrade), | |||
There was a problem hiding this comment.
Why did this comparator change to the exact opposite? Was there a bug in the original line?
There was a problem hiding this comment.
It looks like a bug in the original code -- maybe a confusion between filter and filterNot.
packageName should be define when transactionVersion >= TransactionVersion.minUpgrade.
cc @simonmaxen-da
remyhaemmerle-da
force-pushed
the
remy-lf-1.16
branch
from
57ae43e
to
e23efba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.