Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CVE-2022-0144, resolve shelljs to 0.8.5 #12927

Merged
merged 1 commit into from Feb 14, 2022

Conversation

stefanobaghino-da
Copy link
Contributor

Addresses the following @dependabot alerts:

Introduced #12923 as the apollo package needed to be re-introduced as a development dependency to generate the client-side code for the Navigator GraphQL API.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

changelog_begin
changelog_end
Copy link
Contributor

@S11001001 S11001001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream fix was in shelljs/shelljs#1060.

@stefanobaghino-da
Copy link
Contributor Author

Upstream fix was in shelljs/shelljs#1060.

Yes, thanks. Unfortunately it still hasn't propagated to Apollo, which is why @dependabot couldn't make an automated fix. One of these days I should set aside some time to clean up resolutions that are no longer needed to work around the slow propagation of security patches along the dependency chain.

@stefanobaghino-da stefanobaghino-da merged commit dc5f203 into main Feb 14, 2022
@stefanobaghino-da stefanobaghino-da deleted the ste/CVE-2022-0144 branch February 14, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants