Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsfmt Maven Plugin for Spotless #548

Merged
merged 12 commits into from Mar 29, 2020
Merged

Conversation

source-knights
Copy link
Contributor

@source-knights source-knights commented Mar 26, 2020

Adding the tsfmt as a Maven Plugin.

Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@source-knights
Copy link
Contributor Author

source-knights commented Mar 26, 2020

As mentioned in the encoding issue you fixed for me, I now coded the tsfmt maven plugin. Not sure if I am missing something, but hopefully it will be spot then in this review. Happy to make amendments ,)

I had to disable the new test method for tsconfig based files in my new TypescriptFormatStepTest, cause it is always failing with both, an error about a Legacy "-color" flag that is used and that inputs are missing. I assume the "-color" flag error leads to the inputs missing error message. But I could not figure out why. I see that this color flag is used in the existing base code.

@nedtwigg
Copy link
Member

This looks beautiful, a canonical example of "add maven support for X". Thanks very much. I'll make some changes to the docs and take a look at fixing the @Ignored unit test, then merge and release. Might take a few days before I get to it.

@source-knights
Copy link
Contributor Author

Happy to help if anything comes up. Thx @nedtwigg for the quick response. Stay healthy :)

@nedtwigg nedtwigg merged commit 90a1870 into diffplug:master Mar 29, 2020
@nedtwigg
Copy link
Member

I made some minor changes:

  • changed the default includes from **/*.ts to src/**/*.ts
  • compressed the docs

I made a bigger change, but accidentally pushed to origin/master instead of source-knights/master 😭 and have therefore bricked this PR. The problem is that there's still a problem, which I guess I'll have to make a new issue/PR to resolve...

@nedtwigg
Copy link
Member

nedtwigg commented Apr 2, 2020

Continued in #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants