Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse updates for 4 12 #423

Merged
merged 10 commits into from Jul 26, 2019
Merged

Eclipse updates for 4 12 #423

merged 10 commits into from Jul 26, 2019

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Jul 24, 2019

Provided updates for Eclipse based formatters as they were released for Eclipse 4.12 / 2019-06
Following updates are provided:

@fvgh
Copy link
Member Author

fvgh commented Jul 24, 2019

@nedtwigg If you don't mind, I do this all in one PR. I would appreciate if you could use this branch to provide new versions for:

  • spotless-eclipse-cdt
  • spotless-eclipse-groovy
  • spotless-eclipse-wtp

I don't think that we need a new spotless-eclipse-jdt version. The behaviour has changed (actually some versions ago). Have a look at my comments on the UTs if you are interested.
Anyhow, don't see a need to change the code. Would propose to wait with a new versions when I (finally) finished my work on #292.

In the change logs I left a few TBDs. Will fill the blanks as soon as we have the new versions.

@fvgh
Copy link
Member Author

fvgh commented Jul 24, 2019

This PR will provide fix for #422 .

@nedtwigg
Copy link
Member

Looks great! In progress...

@nedtwigg
Copy link
Member

All three have been published to jcenter and mavencentral.

@fvgh
Copy link
Member Author

fvgh commented Jul 25, 2019

@nedtwigg Tested the new defaults with some projects, including JUnit. Since I used old code versions, nothing changed except for Groovy (see also changes in 1c44cda ).

FYI: I came across a known WTP JSON bug. Since it is already part of 3.8, I see no reason not to upgrade the default.

@fvgh fvgh requested a review from nedtwigg July 25, 2019 22:10
@nedtwigg nedtwigg merged commit 882296d into master Jul 26, 2019
@nedtwigg nedtwigg deleted the eclipse-updates-for-4-12 branch July 26, 2019 15:30
@nedtwigg
Copy link
Member

Released in x.24.0

@k-brooks k-brooks mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants